From 26979079d47095b0118cb47057924328c7666ecf Mon Sep 17 00:00:00 2001
From: dwarning <dwarning>
Date: Mon, 1 Nov 2021 18:12:54 +0100
Subject: [PATCH] prevent few compiler warnings

---
 src/spicelib/devices/nbjt/nbjtdump.c  | 3 ++-
 src/spicelib/devices/nbjt2/nbt2dump.c | 3 ++-
 src/spicelib/devices/numd/numddump.c  | 3 ++-
 src/spicelib/devices/numd2/nud2ask.c  | 1 -
 src/spicelib/devices/numd2/nud2dump.c | 3 ++-
 src/spicelib/devices/numos/nummdump.c | 3 ++-
 6 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/spicelib/devices/nbjt/nbjtdump.c b/src/spicelib/devices/nbjt/nbjtdump.c
index db0cbb130..c78c9f8aa 100644
--- a/src/spicelib/devices/nbjt/nbjtdump.c
+++ b/src/spicelib/devices/nbjt/nbjtdump.c
@@ -72,7 +72,8 @@ NBJTdump(GENmodel *inModel, CKTcircuit *ckt)
 
 	writeAscii = compareFiletypeVar("ascii");
 
-	if (!(fpState = fopen(fileName, (writeAscii ? "w" : "wb")))) {
+	fpState = fopen(fileName, (writeAscii ? "w" : "wb"));
+	if (!fpState) {
 	  perror(fileName);
 	} else {
 	  NBJTputHeader(fpState, ckt, inst);
diff --git a/src/spicelib/devices/nbjt2/nbt2dump.c b/src/spicelib/devices/nbjt2/nbt2dump.c
index bd3d21a7e..4ce4cc614 100644
--- a/src/spicelib/devices/nbjt2/nbt2dump.c
+++ b/src/spicelib/devices/nbjt2/nbt2dump.c
@@ -73,7 +73,8 @@ NBJT2dump(GENmodel *inModel, CKTcircuit *ckt)
 
 	writeAscii = compareFiletypeVar("ascii");
 
-	if (!(fpState = fopen(fileName, (writeAscii ? "w" : "wb")))) {
+	fpState = fopen(fileName, (writeAscii ? "w" : "wb"));
+	if (!fpState) {
 	  perror(fileName);
 	} else {
 	  NBJT2putHeader(fpState, ckt, inst);
diff --git a/src/spicelib/devices/numd/numddump.c b/src/spicelib/devices/numd/numddump.c
index 6d4c9ff3a..25ce945e5 100644
--- a/src/spicelib/devices/numd/numddump.c
+++ b/src/spicelib/devices/numd/numddump.c
@@ -72,7 +72,8 @@ NUMDdump(GENmodel *inModel, CKTcircuit *ckt)
 
 	writeAscii = compareFiletypeVar("ascii");
 
-	if (!(fpState = fopen(fileName, (writeAscii ? "w" : "wb")))) {
+	fpState = fopen(fileName, (writeAscii ? "w" : "wb"));
+	if (!fpState) {
 	  perror(fileName);
 	} else {
 	  NUMDputHeader(fpState, ckt, inst);
diff --git a/src/spicelib/devices/numd2/nud2ask.c b/src/spicelib/devices/numd2/nud2ask.c
index dc71cce1e..178ce00ac 100644
--- a/src/spicelib/devices/numd2/nud2ask.c
+++ b/src/spicelib/devices/numd2/nud2ask.c
@@ -116,5 +116,4 @@ NUMD2ask(CKTcircuit *ckt, GENinstance *inInst, int which, IFvalue *value, IFvalu
     return (E_BADPARM);
   }
   /* NOTREACHED */
-  return (E_BADPARM);
 }
diff --git a/src/spicelib/devices/numd2/nud2dump.c b/src/spicelib/devices/numd2/nud2dump.c
index f4ed70de4..612bd16db 100644
--- a/src/spicelib/devices/numd2/nud2dump.c
+++ b/src/spicelib/devices/numd2/nud2dump.c
@@ -73,7 +73,8 @@ NUMD2dump(GENmodel *inModel, CKTcircuit *ckt)
 
 	writeAscii = compareFiletypeVar("ascii");
 
-	if (!(fpState = fopen(fileName, (writeAscii ? "w" : "wb")))) {
+	fpState = fopen(fileName, (writeAscii ? "w" : "wb"));
+	if (!fpState) {
 	  perror(fileName);
 	} else {
 	  NUMD2putHeader(fpState, ckt, inst);
diff --git a/src/spicelib/devices/numos/nummdump.c b/src/spicelib/devices/numos/nummdump.c
index 5e2fb3d60..7fddbaa4a 100644
--- a/src/spicelib/devices/numos/nummdump.c
+++ b/src/spicelib/devices/numos/nummdump.c
@@ -73,7 +73,8 @@ NUMOSdump(GENmodel *inModel, CKTcircuit *ckt)
 
 	writeAscii = compareFiletypeVar("ascii");
 
-	if (!(fpState = fopen(fileName, (writeAscii ? "w" : "wb")))) {
+	fpState = fopen(fileName, (writeAscii ? "w" : "wb"));
+	if (!fpState) {
 	  perror(fileName);
 	} else {
 	  NUMOSputHeader(fpState, ckt, inst);