From c5a3788f6b9d9b7dc87d3ed3a310837214a65877 Mon Sep 17 00:00:00 2001 From: rlar Date: Sat, 28 Mar 2015 12:09:44 +0100 Subject: [PATCH] hisimhv2, TMFx, globals need to be static or need an own namespace Fixme, actually these should have block local scope. (local in the blocks of the macros where these variables are actually used) Thats safer, much easier to understand, at least as fast, and won't defeat parallelisation. --- src/spicelib/devices/hisimhv2/hsmhveval.c | 3 +-- src/spicelib/devices/hisimhv2/hsmhveval_rdrift.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/spicelib/devices/hisimhv2/hsmhveval.c b/src/spicelib/devices/hisimhv2/hsmhveval.c index 00ff779e4..081a2e294 100644 --- a/src/spicelib/devices/hisimhv2/hsmhveval.c +++ b/src/spicelib/devices/hisimhv2/hsmhveval.c @@ -135,8 +135,7 @@ June 2008 (revised October 2011) #define C_gidl_delta 0.5 /* local variables used in macro functions */ -double TMF0 , TMF1 , TMF2 , TMF3 , TMF4 , TMF5 , TMF6 ; -double TCF0 , TCF1 , TCF2 , TCF3 , TCF4 , TCF5 ; +static double TMF0 , TMF1 , TMF2 , TMF3 , TMF4 ; /*===========================================================* * Exp() for PGD. diff --git a/src/spicelib/devices/hisimhv2/hsmhveval_rdrift.c b/src/spicelib/devices/hisimhv2/hsmhveval_rdrift.c index 069a31ef9..6045ae5bf 100644 --- a/src/spicelib/devices/hisimhv2/hsmhveval_rdrift.c +++ b/src/spicelib/devices/hisimhv2/hsmhveval_rdrift.c @@ -75,7 +75,7 @@ June 2008 (revised October 2011) #include "hsmhvevalenv.h" /* local variables used in macro functions */ -double TMF0 , TMF1 , TMF2 , TMF3 , TMF4 , TMF5 , TMF6 ; +static double TMF0 , TMF1 , TMF2 , TMF3 ; /*===========================================================* * pow